search

strangetom / ingredient-parser

A tool to parse recipe ingredients into structured data
https://ingredient-parser.readthedocs.io/en/latest/
MIT License
72 stars 12 forks source link

Parses "cloves" ingredient incorrectly #11

Closed boxydog closed 8 months ago

boxydog commented 8 months ago

Parses "1 tsp cloves" as an amount "1 tsp clove" with no ingredient. Should be "cloves" as an ingredient.

image
strangetom commented 8 months ago

This one has caused a lot of problems, and I thought I'd solved it but clearly not. Training a model from the latest develop branch seems to do the right thing now, so it will be fixed in the next release. I'll write some tests to make sure it doesn't get missed again.

boxydog commented 8 months ago

Thanks!

strangetom commented 8 months ago

0e4246732f add some tests to check that the various uses of "cloves" are parsed correctly. cf65f1687d adds a new model that passes these tests.

This is still in the develop branch for now, but I'll close this issue as completed.