stranoweb / stranoweb-ajax-login

Wordpress plugin to add ajax login, register, forgot password and logout modal popups and more.
2 stars 0 forks source link

registration_errors filter is not called when ajax login is active #19

Closed ykopstein closed 3 years ago

ykopstein commented 3 years ago

The registration_errors hook is not fired when ajax login is active. This prevents other plugins from adding validation to the registration process when ajax login is active.

I wrote simple test code (below) and many of the documented wordpress registration hooks are not fired. The code below shows only the following hooks fire:

    add_filter( 'user_registration_email', function($value) {
        Logger::Log('user_registration_email');
        return $value;
    }, 10, 1);

    add_action( 'register_post', function() {
        Logger::Log('register_post');
    });

    add_filter( 'registration_errors', function($errors) {
        Logger::Log('registration_errors');
        return $errors;
    }, 10, 1);

    add_filter( 'pre_user_login', function($value) {
        Logger::Log('pre_user_login');
        return $value;
    }, 10, 1);

    add_filter( 'pre_user_email', function($value) {
        Logger::Log('pre_user_email');
        return $value;
    }, 10, 1);

    add_filter( 'pre_user_nicename', function($value) {
        Logger::Log('pre_user_nicename');
        return $value;
    }, 10, 1);

    add_filter( 'pre_user_url', function($value) {
        Logger::Log('pre_user_url');
        return $value;
    }, 10, 1);

    add_filter( 'pre_user_nickname', function($value) {
        Logger::Log('pre_user_nickname');
        return $value;
    }, 10, 1);

    add_filter( 'pre_user_first_name', function($value) {
        Logger::Log('pre_user_first_name');
        return $value;
    }, 10, 1);

    add_filter( 'pre_user_last_name', function($value) {
        Logger::Log('pre_user_last_name');
        return $value;
    }, 10, 1);

    add_filter( 'pre_user_display_name', function($value) {
        Logger::Log('pre_user_display_name');
        return $value;
    }, 10, 1);

    add_filter( 'pre_user_description', function($value) {
        Logger::Log('pre_user_description');
        return $value;
    }, 10, 1);

    add_filter( 'wp_pre_insert_user_data', function($data) {
        Logger::Log('wp_pre_insert_user_data');
        return $data;
    }, 10, 1);

    add_action( 'user_register', function() {
        Logger::Log('user_register');
    });

    add_action( 'register_new_user', function() {
        Logger::Log('register_new_user');
    });
stranoweb commented 3 years ago

Hi,

Thanks for the very accurate reporting, i will check my plugin.

Best, Marco

stranoweb commented 3 years ago

We have just released a new update with that and another hook added to the registration process so it’s now compatible with the plugins that use that hook. Thanks for the suggestion. Best