strapi-community / strapi-plugin-local-image-sharp

Dynamically resize, format and optimize images based on url modifiers.
https://strapi-community.github.io/strapi-plugin-local-image-sharp/
66 stars 19 forks source link

feat: add `maxAge` option for Cache-Control HTTP response header #20

Closed candidosales closed 1 year ago

candidosales commented 1 year ago

Issue: https://github.com/strapi-community/strapi-plugin-local-image-sharp/issues/19

candidosales commented 1 year ago

@stafyniaksacha , I made a PR. Could you review it and test it? https://github.com/strapi-community/strapi-plugin-local-image-sharp/pull/20

stafyniaksacha commented 1 year ago

Hello @candidosalesn, tahnks for your contribution! can you run yarn run eslint:fix on your branch ?

candidosales commented 1 year ago

@stafyniaksacha, it's fixed, also I upgraded the babel-eslint (deprecated) for @babel/eslint-parser;

candidosales commented 1 year ago

@stafyniaksacha, it's ready for the second review.

candidosales commented 1 year ago

Could you update the link on the ]Releases page](https://github.com/strapi-community/strapi-plugin-local-image-sharp/releases)?

The link is pointing to https://github.com/strapi-community/strapi-plugin-rest-cache/blob/main/CHANGELOG.md.

CleanShot 2023-02-27 at 22 35 31@2x

stafyniaksacha commented 1 year ago
  • Upgrade version 1.5.0 in package.json;

Oops, didn't noticed this. Released as 1.6.0 as it's automatically bumped!

Also updated the changelog link, thanks for pointing it :)

candidosales commented 1 year ago

It's working! Thanks! 😄

CleanShot 2023-02-28 at 09 42 43@2x