search

strapi-community / strapi-plugin-publisher

A plugin for Strapi Headless CMS that provides the ability provides the ability to easily schedule publishing and unpublishing of any content type.
https://market.strapi.io/plugins/strapi-plugin-publisher
MIT License
48 stars 17 forks source link

Mode missing for ActionDateTimePicker #108

Closed FlashThePlayer closed 1 year ago

FlashThePlayer commented 1 year ago

Hi, I do think the mode property for the ActionDateTimePicker component is missing? Under admin/src/components/Action/Action.js the ActionTimePicker is build like

<ActionTimePicker onChange={handleDateChange} executeAt={executeAt} isCreating={isCreating} isEditing={isEditing} />

But i guess it should be

<ActionTimePicker onChange={handleDateChange} executeAt={executeAt} isCreating={isCreating} isEditing={isEditing} mode={mode} />

Without the mode attribute the header of the date picker looks like this

Screenshot 2023-10-05 at 11 55 13

With the attribute set I get the corrcet display

Screenshot 2023-10-05 at 11 54 07

Also how do you like feature requests? I currently the date format is not changeable? Is it possible that you could add a locale attribute to the settings like the same way you do step? Or is a pull request better for a request like this?

Anyway thx for the plugin, it makes live way easier!

ComfortablyCoding commented 1 year ago

Thanks for the report!

That looks to be the case, not sure how that got through :)

In terms of feature requests a PR over an issue is fine. PRs are always welcome.

If you end up doing a PR for both of the mentioned things I would prefer they each be done in their own PRs. I try to keep it to one PR per bug/feature etc.