Closed Blagoj5 closed 1 year ago
I can't really tag reviewers, so I'll ping with this comment @Lith @dgmike :sweat_smile:
Patch coverage: 54.54
% and project coverage change: -3.04
:warning:
Comparison is base (
b5fa17e
) 81.48% compared to head (067688b
) 78.44%.:exclamation: Current head 067688b differs from pull request most recent head 6f47e5e. Consider uploading reports for the commit 6f47e5e to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @Blagoj5 ! Could you please signing your commits ? I'm unable to merge without it :/
It should be signed now, tell me if you have any problems. I wasn't aware this was an requirement sorry. @Lith
Problem
There is currently a bug in the code especially on
line 46
where publicFIles is always true, e.gSolution
Make sure we do proper checking with the new util function
setConfigField
in case if the config value is string, undefined or an actual boolean. I didn't see a reason to really add tests for this, but if you guys want to do this, I can take care of it.