strapi-community / strapi-provider-upload-google-cloud-storage

Google Cloud Storage Upload Provider for Strapi
MIT License
210 stars 90 forks source link

Support for latest Node LTS (20) #181

Open JakobLierman opened 10 months ago

JakobLierman commented 10 months ago

Describe the bug It is not possible to use Node 20 with this package. error @strapi-community/strapi-provider-upload-google-cloud-storage@4.10.5: The engine "node" is incompatible with this module. Expected version "^16 || ^18". Got "20.9.0"

To Reproduce Steps to reproduce the behavior:

  1. Use Node 20.
  2. Try to install this package.

Expected behavior Installation succeeds.

Desktop (please complete the following information):

Additional context

galago commented 9 months ago

Any plan to fix the plugin or is it abandoned?

rishi0428 commented 9 months ago

Hey, Facing the same issue. Is there any update on it?

JakobLierman commented 8 months ago

@Lith is this package abandoned? If so, make sure to archive it, so people know they should not use this anymore.

julesrenaud commented 8 months ago

@Lith is this package abandoned? If so, make sure to archive it, so people know they should not use this anymore.

@JakobLierman it still works, even with node v20. The incompatibility error is a warning, in fact it works as it should. https://classic.yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-ignore-engines

JakobLierman commented 8 months ago

@Lith is this package abandoned? If so, make sure to archive it, so people know they should not use this anymore.

@JakobLierman it still works, even with node v20. The incompatibility error is a warning, in fact it works as it should. classic.yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-ignore-engines

Agreed, but warnings are there for a reason. yarn install now never shows the same warning for other packages (that might break my code).

Since it doesn't break anything, I can't imagine that the changes to this repo will be very time consuming.

julesrenaud commented 8 months ago

@JakobLierman as far as I understand there's very little to do, we would just need for someone else to takeover the repo