fix: accordian style - Githubissues

strapi / design-system

Strapi.io's design system :rocket:

https://design-system.strapi.io

MIT License

459 stars 158 forks source link

fix: accordian style #1774

Closed madhurisandbhor closed 4 weeks ago

madhurisandbhor commented 1 month ago

What does it do?

Fix accordian style, https://github.com/strapi/strapi/issues/20789

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
design-system	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 6, 2024 9:22am

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 1ea7e4ad2cc48b4cd40f463437833d80b2632426

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | --------------------- | ----- | | @strapi/design-system | Patch | | @strapi/icons | Patch | | @strapi/ui-primitives | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lucasboilly commented 1 month ago

Hey @madhurisandbhor, here are the remaining issues:

After clicking on it, if my pointer leaves the hover state disappears but a blue border remains https://github.com/user-attachments/assets/3aa90f7b-a74f-4c0b-ae7d-e7b4760a6abe
When hovering a disabled one, a blue border appears but it shouldn't be the case https://github.com/user-attachments/assets/83df1601-40ca-49be-9813-f8e209dfc078
We shouldn't have icons on the "L" variant, because we'll need to remove them everywhere in the settings
The icon buttons in this variant don't have the right colors, maybe is there an override?
In a group we would need a border top or bottom on each accordion to separate them

Feranchz commented 4 weeks ago

@lucasboilly should be ready now. Just a few comments:

After clicking on it, if my pointer leaves the hover state disappears but a blue border remains https://github.com/user-attachments/assets/3aa90f7b-a74f-4c0b-ae7d-e7b4760a6abe

I think this is right. It's true that your pointer leaves but the focus is still on the element, the border disappear when you change the focus to another part, I think it's the right way.

The icon buttons in this variant don't have the right colors, maybe is there an override?

Yes, it's a override that only happens on the Storybook, is not happening at the CMS so I think is fine.

alexandrebodin commented 4 weeks ago

@remidej I think you can go ahead and merge since madhuri isn't here anymore

remidej commented 4 weeks ago

Yes @Feranchz took over the work, I just want Lucas to confirm the PR fixes the issue

lucasboilly commented 4 weeks ago

Hey @Feranchz :)

The behavior was different in v4 but maybe it's better like this
Ok!

@remidej that's all good, let's merge it 👍