strapi / design-system

Strapi.io's design system :rocket:
https://design-system.strapi.io
MIT License
473 stars 167 forks source link

<DatePicker /> component autoComplete issue #1798

Open alexandermirzoyan opened 1 month ago

alexandermirzoyan commented 1 month ago

What does it do?

Added autoComplete="off" prop to <DatePicker /> component by default.

Why is it needed?

Fixes issue with browser's default behaviour.

How to test it?

Make sure that you have some suggestions from the browser and click on input tag from the <DatePicker /> component.

Related issue(s)/PR(s)

https://github.com/strapi/design-system/issues/1797

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 9a23178497cbb53935abd242959b2c7a7ab5eedb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 9:46am
hanpaine commented 1 month ago

Hey @alexandermirzoyan thanks for your contribution. We've migrated to the DS v2 now; can you verify if you're still seeing the issue please as the PR is currently pointed at our v2 (v1 is maintained on branch /v1 and only High and Criticals are supported there right now). Cheers!

alexandermirzoyan commented 1 month ago

Am I correct that DS v2 is working with Strapi's v5?

remidej commented 3 weeks ago

@alexandermirzoyan yes Strapi 5 uses the latest design system v2 RC

Marc-Roig commented 2 weeks ago

@alexandermirzoyan thank you for the contribution! As a final step, could you update the changeset?

We use this mechanism to keep track of all changes, you can see the docs here

you can see an example of how we update it

markkaylor commented 1 day ago

@alexandermirzoyan if you have a second to add a changeset looks like we can merge 🚀

Let us know if anything isn't clear in the doc for adding the changeset