search

strapi / design-system

Strapi.io's design system :rocket:
https://design-system.strapi.io
MIT License
473 stars 167 forks source link

fix: combobox primitive empty state when autocomplete is none #1816

Closed HichamELBSI closed 2 weeks ago

HichamELBSI commented 2 weeks ago

What does it do?

This PR fixes the existing issue that always renders the No result found (empty state) of the combobox when autocomplete is set to off.

Why is it needed?

Avoid rendering the No result found at the end of the option list (when autocomplete = none) which is the case in all Strapi Cloud combobox.

How to test it?

Added new unit tests to handle this use case

Related issue(s)/PR(s)

https://github.com/strapi/design-system/issues/1803

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: f2ad83ec069cf2a279b1cfd0852f7a56fc5b608a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | --------------------- | ----- | | @strapi/ui-primitives | Major | | @strapi/design-system | Major | | @strapi/icons | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 11:44am