search

strapi / foodadvisor

🥘 THE Strapi demo application
MIT License
1.09k stars 446 forks source link

Update to latest beta version #22

Closed derrickmehaffy closed 5 years ago

derrickmehaffy commented 5 years ago

Updating the api to latest strapi beta version because it was still on beta.0, lots of bug fixes since then

lauriejim commented 5 years ago

@derrickmehaffy Do you know about the travis error?

davidkartuzinski commented 5 years ago

@derrickmehaffy thanks to @alexandrebodin - the fix for this Travis error is to add: dist: trusty to the top of the .travis.yml file. I had the same errors but they went away with this.

derrickmehaffy commented 5 years ago

Also we need to remove node 11 from Travis.

I'll update the PR shortly with some changes

derrickmehaffy commented 5 years ago

I'm not entirely sure what the purpose of the xvfb is here? And that appears to be the issue: 

The command "sh -e /etc/init.d/xvfb start" failed and exited with 127 during .
alexandrebodin commented 5 years ago

@derrickmehaffy David fixed it in another PR you need to use dist: trusty

derrickmehaffy commented 5 years ago

Mmmmm this should be something that needs a more deep look into, testing on Ubuntu 14.04 really won't provide much considering it's EOL later on.

image

alexandrebodin commented 5 years ago

@derrickmehaffy you can make the right update following this documentation :) https://www.google.com/search?q=travis+xvbf+xenial&rlz=1C5CHFA_enFR842FR842&oq=travis+xvbf+xenial&aqs=chrome..69i57j0.3172j0j1&sourceid=chrome&ie=UTF-8

lauriejim commented 5 years ago

I tested with last version and I made other function updates See here: https://github.com/strapi/foodadvisor/pull/25 I think we have to marge the #25 PR instead of this one.

alexandrebodin commented 5 years ago

Closing this PR as it is outdated compared to https://github.com/strapi/foodadvisor/pull/26