search

strapi / nextjs-corporate-starter

Strapi Demo application for Corporate Websites using Next.js
MIT License
1.08k stars 338 forks source link

adding possibility to create new pages on strapi without changeing frontend #46

Closed KennyAtCodin closed 1 year ago

KennyAtCodin commented 1 year ago

Please review and let me know if it works for you :)

PaulBratslavsky commented 1 year ago

@KennyAtCodin will review later this week. Thank you for the PR.

diramazioni commented 1 year ago

Thanks, @KennyAtCodin it works for me I've just made a small fix #52 because I don't get back any metadata. How did you get it to work? I guess it works for you because otherwise, you would get an error.

Moreover section-renderer needs to include more available cases

PaulBratslavsky commented 1 year ago

@KennyAtCodin thanks for the PR will merge today.

@diramazioni I will look at your fix as well, in terms of the metadata not being present, I think there might be a bug that was introduced in the SEO plugin. I will take a look at that.

diramazioni commented 1 year ago

@PaulBratslavsky I had configure the SEO plugin for the Page then it works. However I find it rather confusing to have a metadata component and the SEO component, Which one is better and internationalized?

KennyAtCodin commented 1 year ago

@diramazioni: I suggest using the SEO component, it has a nice preview feature. Internationalized are both, because of the way strapi handles internationalization. There is an open PR https://github.com/strapi/nextjs-corporate-starter/issues/32 I didn't had the chance to get to this yet. Maybe if you have time you could implement this.