Convert SEO plugin to strapi v5

strapi / strapi-plugin-seo

The official plugin to make your Strapi content SEO friendly

95 stars 41 forks source link

Convert SEO plugin to strapi v5 #76

Closed jhoward1994 closed 1 month ago

jhoward1994 commented 2 months ago

What does it do?

Converts the SEO plugin to strapi v5

Related issue(s)/PR(s)

https://strapi-inc.atlassian.net/browse/DX-1428

Uses additional exports added to the monorepo to be tested with https://github.com/strapi/strapi/pull/21209 if not merged

To test:

Clone this branch
Run this in the plugin codebase yarn; yarn run watch:link - This will publish the package to yalc locally. (make sure to install yalc globally https://www.npmjs.com/package/yalc)
In a strapi v5 app run yarn dlx yalc add --link @strapi/plugin-seo && yarn install. This will install the plugin as a dependency from yalc

DX-1428

jhoward1994 commented 2 months ago

I've found some bugs in the injected CM SEO component - working through them now. Will set this ready to review once that is done

MDSilviu commented 1 month ago

Any ETA on this PR? As v5 of strapi is officially released i wonder when we can get this plugin working again with the new version

reslear commented 1 month ago

any news?

namnhfreelancer commented 1 month ago

any updates ?

hanpaine commented 1 month ago

Hi folks - we're working on it in earnest, it has required some unblocking of bugs first. Thanks for your patience 🙏 it's coming soon!

Mcastres commented 1 month ago

Hello @jhoward1994 👋 Thanks for working on this!

I added the plugin in the LaunchPad application. I have two feedback:

It seems that there is a CSS issue concerning the SEO block component
When clicking on "See details", I have this error:

jhoward1994 commented 1 month ago

When clicking on "See details", I have this error: Can you confirm you've installed the plugin like this

Clone this branch
Run this in the plugin codebase yarn; yarn run watch:link - This will publish the package to yalc locally. (make sure to install yalc globally npmjs.com/package/yalc)
In a strapi v5 app run yarn dlx yalc add --link @strapi/plugin-seo && yarn install. This will install the plugin as a dependency from yalc

You can see the docs here https://docs.strapi.io/dev-docs/plugins/development/create-a-plugin#linking-the-plugin-to-your-project

This is known issue with strapi when running in production with locally installed plugins - the yalc installation approach above should work

jhoward1994 commented 1 month ago

@Mcastres

ffb5302 (#76) Will fix the styling to look like the image above

(ignore the preview button, that is added in the monorepo example and nothing to do with the SEO plugin)

NEDDL commented 1 month ago

@innerdvations @Mcastres @Bassel17 any ETA for this merge?

jhoward1994 commented 1 month ago

Will do on the padding.

The icon color is a limitation on the design system. I will be making that change through https://github.com/strapi/design-system/pull/1794 but think we can continue with this in the meantime. Wdyt?

Mcastres commented 1 month ago

Will do on the padding.

The icon color is a limitation on the design system. I will be making that change through strapi/design-system#1794 but think we can continue with this in the meantime. Wdyt?

Sure, let's continue with this for now :)

jhoward1994 commented 1 month ago

Tested via https://www.npmjs.com/package/@strapi/plugin-seo/v/2.0.0-rc.1

I will publish v2 to npm from main after merging this PR