fix seo component - Githubissues

strapi / strapi-starter-gatsby-corporate

strapi-starter-gatsby-corporate-git-main-strapijs.vercel.app

MIT License

27 stars 8 forks source link

fix seo component #15

Closed markkaylor closed 3 years ago

markkaylor commented 3 years ago

Fixes the Gatsby Helmet SEO component, removes Next SEO component
Replaces incorrect next env var with gatsby env var
Fixes a bug when turning off preview mode locales disappear

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/strapijs/strapi-starter-gatsby-corporate/G29ZPoDtRy7eGLAzvpZ7PABmc92G
✅ Preview: https://strapi-starter-gatsby-corporate-git-fix-seo-strapijs.vercel.app

[Deployment for 6fb2e0f canceled]

remidej commented 3 years ago

Hey Mark, thanks for the changes.

It looks like it's going to conflict with the changes I've made on the dev/new-souce-plugin branch. Is it okay if I take over this PR, as we discussed yesterday? So you can focus on the CLI topics

I think I'd prefer to wait for the new source plugin PR to be merged (it's almost ready), then I can rebase this branch and fix the conflicts. I would ask for your review of course

Does this sound good?

markkaylor commented 3 years ago

Hey @remidej Sounds good, thanks!

But right now there is an incorrect env variable in the localize file.

It's a quick fix I think we should do ASAP. I'll do it first thing tomorrow morning on a new branch. It's breaking the locale switch.