Migrate to gatsby-source-strapi v1

strapi / strapi-starter-gatsby-corporate

strapi-starter-gatsby-corporate-git-main-strapijs.vercel.app

MIT License

27 stars 8 forks source link

Migrate to gatsby-source-strapi v1 #16

Closed remidej closed 3 years ago

remidej commented 3 years ago

Hello!

Here's what this PR does:

Migrate the starter to gatsby-source-strapi
Remove the gatsby-plugin-graphql-image, since we're not using graphql anymore
Attempts to fix secret mode issues

Here are the issues that I know about it:

All images from contentSections are not handled by GatsbyImage (so most images on the starter are dumb tags). But this problem is a gatsby-source-plugin issue (media fields are not parsed when they're inside dynamic zones), so I don't think we need to fix it in this starter. However, it will be a priority for the next major gatsby-plugin-strapi release.
Preview mode requires you to set the locale prefix in the URL, even though most other pages don't. I didn't remember how we handled the locale prefix for normal pages in the end, so I'll let you look at this one Mark
Clicking on the Strapi navbar logo from a preview mode page goes to "/:locale/preview/", which is a 404

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/strapijs/strapi-starter-gatsby-corporate/aMFng65eMeKkToQEVNZV4Z4w4v4r
✅ Preview: https://strapi-starter-gatsby-corporate-git-dev-new-sou-451921-strapijs.vercel.app

markkaylor commented 3 years ago

Hey looks good to me @remidej . I opened #21 off of your branch to fix preview mode and some other things. The images are working on that branch 🤷‍♂️. I rebased main on to my branch without thinking 🤦. I think if you do the same here I could change the base on my PR and merge it into yours (if you agree with the changes).

remidej commented 3 years ago

@markkaylor the problem with images is that they're only dumb tags, they don't leverage Gatsby's image handling. But they still work fine 👍

I think we should be good to go for this PR!

markkaylor commented 3 years ago

Something strange going on with the image here: Screenshot 2021-07-21 at 15 32 59

remidej commented 3 years ago

I found that around tablet sizes, the image was indeed stretched. I tried changing the media queries, does it work for you?

markkaylor commented 3 years ago

Seems to be working fine in Firefox 🙃 but still stretched in chrome 😢

firefox:

chrome:

remidej commented 3 years ago

Thanks, I hadn't tested it in Chrome. Can you try again?