strapi / strapi-starter-next-corporate

Next.js starter for creating a corporate site with Strapi.
https://strapi-starter-next-corporate.vercel.app
MIT License
346 stars 95 forks source link

add i18n #32

Closed markkaylor closed 3 years ago

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/strapijs/strapi-starter-next-corporate/D6StCMWVUF3EjWsnVZdRrgYP4yWa
✅ Preview: https://strapi-starter-next-corporate-git-feat-i18n-strapijs.vercel.app

markkaylor commented 3 years ago

Hey @remidej can you take a look?

remidej commented 3 years ago

Hey @markkaylor, sorry for checking this so late. The new locale switch dropdown is beautiful ✨

I can't seem to get the warning you're talking about. Here's what happens on my end:

markkaylor commented 3 years ago

No worries @remidej kudos to @rgesulfo for the dropdown, I dig it too.

Ok yeah for me it has a 404 but then redirects to the proper fr homepage, maybe we can take a look together tomorrow.

markkaylor commented 3 years ago

@remidej @alexandrebodin - Updated to use a string as a slug and the same slug for both locales. Thanks for your help :)

If you have time to take a look that would be awesome. Here's Gatsby as well: https://github.com/strapi/strapi-starter-gatsby-corporate/pull/14

remidej commented 3 years ago

But let's wait for the template repo to be updated first before we merge this