feat/with tailwind v2 - Githubissues

strapi / strapi-starter-next-corporate

Next.js starter for creating a corporate site with Strapi.

https://strapi-starter-next-corporate.vercel.app

MIT License

346 stars 95 forks source link

feat/with tailwind v2 #38

Closed gfortaine closed 3 years ago

gfortaine commented 3 years ago

feat: with-tailwind-v2
feat: with-next11
refactor: replace classnames by clsx
refactor: upgrade package.json

vercel[bot] commented 3 years ago

@gfortaine is attempting to deploy a commit to the Strapi Team on Vercel.

A member of the Team first needs to authorize it.

remidej commented 3 years ago

On paper this looks great! I'll test it soon, but I'm pretty excited about this

capsloq commented 3 years ago

exicted for this one to go through the testing

remidej commented 3 years ago

Hello and thanks again for the PR. I wanted to update the Tailwind version for a while too. I'm not merging it because I prefer to keep using classnames for consistency, since that's what other starters are using, and the difference is minimal. Also, since I took a while to review it, the Tailwind versions weren't the latest anymore.

So I opened another PR that includes most of your changes (#50), which we'll merge instead of this one