fix(history): handle sanitization when fetching versions

[markkaylor]

What does it do?

• Adjust history sanitization so it doesn't break the e2e tests
• Build media and relations object in their own dedicated functions

How to test?

• The e2e tests for history should pass (locally I have them passing as before they were broken, here in the CI they are sometimes flaky but I think it is unrelated)
• History versions and their relations should not return sensitive data
• Verify everything is working as normal (missing relations, restoration, etc...)
• Admin user relations should not be completely sanitized out of the response

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
contributor-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2024 8:18am

[Marc-Roig]

I would rather not tie data population with sanitization if possible, and looking at this situation, would it be possible to keep the entry structure the same (without the results & meta object wrapping it) , and keeping a context of missing relations?

[markkaylor]

I would rather not tie data population with sanitization if possible, and looking at this situation, would it be possible to keep the entry structure the same (without the results & meta object wrapping it) , and keeping a context of missing relations?

I would be very interested in refactoring to find a better solution in an immediate follow up PR, but I was thinking of this PR as a patch to fix failing e2e tests currently on v5/main.

I also have this PR open that refactors history quite a bit: https://github.com/strapi/strapi/pull/20179 as well, so it might be nice to have that before making big changes here.

wdyt? Would you prefer I handle the refactor now on this PR?

[Marc-Roig]

sounds good to me to move this forward to fix the e2e 🥳