search

strapi / strapi

🚀 Strapi is the leading open-source headless CMS. It’s 100% JavaScript/TypeScript, fully customizable and developer-first.
https://strapi.io
Other
60.6k stars 7.57k forks source link

chore(tests): update snapshots #20214

Closed markkaylor closed 2 weeks ago

markkaylor commented 2 weeks ago

What does it do?

Why is it needed?

How to test it?

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 11:54am
joshuaellis commented 2 weeks ago

I think this is flakey because of an effect in the header i wonder if we should waitFor the header to have the style height? 🤔

markkaylor commented 2 weeks ago

I think this is flakey because of an effect in the header i wonder if we should waitFor the header to have the style height? 🤔

I had it failing consistently on https://github.com/strapi/strapi/pull/20212 but looks like it's passing now after pulling in v5/main again 🤷‍♂️ closing this one.