Closed innerdvations closed 1 week ago
vercel[bot]
commented
2 weeks ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| contributor-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 29, 2024 2:54pm |
github-actions[bot]
commented
2 weeks ago Size Change: 0 B
Total Size: 2.58 MB
innerdvations
commented
2 weeks ago So far this has run four times locally and twice on the CI with only the content history failing, so I think this helps a lot compared to before
jhoward1994
commented
2 weeks ago I haven't seen that content releases FE failure before. Maybe we could skip the test here if it keep failing to get the E2E CI to run?
innerdvations
commented
2 weeks ago I haven't seen that content releases FE failure before. Maybe we could skip the test here if it keep failing to get the E2E CI to run?
It just has to be run again sometimes, someone is working on that too and then we should have stable tests again everywhere!
innerdvations
commented
2 weeks ago login.spec.ts just failed 😭 I'll take one more look at it, but at least it's the only e2e test that has failed in the last 10 runs or so.
joshuaellis
commented
2 weeks ago login.spec.ts just failed 😭 I'll take one more look at it, but at least it's the only e2e test that has failed in the last 10 runs or so.
can you share a trace?
innerdvations
commented
2 weeks ago login.spec.ts just failed 😭 I'll take one more look at it, but at least it's the only e2e test that has failed in the last 10 runs or so.
can you share a trace?
Just the one in CI: https://github.com/strapi/strapi/actions/runs/8880591655/job/24382167567?pr=20223
Most of the fixing I've done in there is the same flaky login in general, compounded by creating multiple browsers. Whatever is going wrong here is probably another case I missed where we're not waiting for something.
joshuaellis
commented
2 weeks ago I've looked at your trace file, the issue is a bug in the FE which imo is high, i'm gonna open a JIRA ticket and attach the trace file, not sure how to reproduce it though...
EDIT: DX-1397
innerdvations
commented
1 week ago I think I can do a much more minimalist PR, this one had too many guesses in it, so I'll close this for now and come back with a cleaner version.
What does it do?
Why is it needed?
For some reason, almost consistently near the end of a test run, the login will fail to load the page and gets an infinitely spinning loader instead. We really need to fix that, but until we can solve it, this will get our e2e CI working again since right now it's nearly impossible to get e2e to pass.
How to test it?
CI e2e tests should pass
Related issue(s)/PR(s)
Once I'm sure this passes consistently on the CI, I'll cherry pick this and do the same thing on develop
DX-1393
v4 version of this PR