vercel[bot]
commented
3 weeks ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| contributor-docs | ❌ Failed (Inspect) | May 28, 2024 8:10am |
Closed madhurisandbhor closed 11 hours ago
vercel[bot]
commented
3 weeks ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| contributor-docs | ❌ Failed (Inspect) | May 28, 2024 8:10am |
github-actions[bot]
commented
3 weeks ago Size Change: 0 B
Total Size: 2.53 MB
Marc-Roig
commented
6 days ago probably someelse (FE) should approve this pr too :)
simotae14
commented
1 day ago I found two strange behaviours, not sure are related to this PR to be honest. The first one is the alignment of the confirmation message, as you can see the text in red is not aligned with the other message
the second weird behaviour are some warning with message "Not found" that are shown when we switch from a document with entries to another one without entries as you can see in this video
https://github.com/strapi/strapi/assets/2589748/5dc3ee9e-6bd6-4fe4-8f1a-4a7daa2f4796
simotae14
commented
1 day ago And also some validation error messages have no useful meaning, for example
Feranchz
commented
1 day ago Thanks for the errors @simotae14 !
I discovered a couple of things:
useDoc hook, probably we can go with this PR and create a ticket for that error, but before lets take a look at other teams to know if someone else is already taking a look at this closingPeriod.dish is always throwing an errorFor this last one we can create a ticket because it's a more complicated thing and I think is a v4 error too (I remember something similar in Releases which works the same way) 🤔
madhurisandbhor
commented
15 hours ago New changes on fetching entries on opening modal LGTM, thanks!! Noticed 2 issues,
Would like to know why don't we use publishedAt value?
Feranchz
commented
14 hours ago Would like to know why don't we use publishedAt value?
@madhurisandbhor because right now we have two versions of the entry (the published one and the in draft one). We want to use the one in draft (to validate it) and in this version publishedAt is null (because is in draft), but we want the "status" (which takes in consideration all the versions of the entry).
Actually this change is interesting, probably we want to discuss it more with Yannis
Could you add these two issues you found to the blitz docs? 🙏
What does it do?
Bulk Publish action migrated to v5 without any v5 design changes.
Related issue(s)/PR(s)
⚠️ Merge after https://github.com/strapi/strapi/pull/20235 as this is created on top of it