search

strasdat / Sophus

C++ implementation of Lie Groups using Eigen.
Other
2.07k stars 599 forks source link

SOPHUS_USE_BASIC_LOGGING=ON compilation error #516

Closed Lishen1 closed 5 months ago

Lishen1 commented 1 year ago

Describe the bug [A clear and concise description of what the bug is.]

To Reproduce turn on SOPHUS_USE_BASIC_LOGGING=ON build on windows msvc

  do {                                                                        \
    if (!(expr)) {                                                            \
      SOPHUS_DEDAULT_ENSURE_FAILURE_IMPL(SOPHUS_FUNCTION, __FILE__, __LINE__, \
                                         ##__VA_ARGS__);                      \
    }                                                                         \
  } while (false)
#endif

as i think here (and next too) should be #VA_ARGS (stringification) instead of ##VA_ARGS (concatination) at least it fix compilation errors Expected behavior [A clear and concise description of what you expected to happen.]

Sophus version: commit hash commit 61f9a9815f7f5d4d9dcb7f4ad9f4f42ab3563108 (grafted, HEAD, origin/main-1.x, origin/HEAD, main-1.x) [Commit hash on main branch which has the bug. Please test on HEAD of main first before submitting a bug.]

Additional context

strasdat commented 5 months ago

This should be fixed by #538, since it removes BASIC_LOGGING and the fmt dependency and includes corresponding CI coverage.