Fix path distortion on vertical connection lines

strathausen / dracula

JavaScript layout and representation of connected graphs.

https://www.graphdracula.net

MIT License

836 stars 132 forks source link

Fix path distortion on vertical connection lines #56

Closed alfadur closed 4 years ago

alfadur commented 4 years ago

Corrects the computation of anchor points of connections curves.

Anchor offsets for the destination point of a vertical connection used the source point coordinate (y1) instead of destination point coordinate (y4), and the offset directions were flipped (used +dy for the north offset, and -dy for the south offset).

strathausen commented 4 years ago

Nice catch, thanks!

alfadur commented 4 years ago

You're welcome! 🙂

alfadur commented 4 years ago

Any particular reason you didn't want to merge this? 🙂

strathausen commented 4 years ago

I think I was tired and pushed the wrong button!

alfadur commented 4 years ago

OK, I imagine I could've easily done the same, haven't dealt with GitHub pull requests in ages 😃