stratiformltd / react-loadable-visibility

A wrapper around react-loadable and @loadable/component to load elements once they are visible on the page.
BSD 3-Clause "New" or "Revised" License
1.01k stars 31 forks source link

Failed to execute 'unobserve' on 'Intersection Observer' #24

Closed sauravvarma closed 5 years ago

sauravvarma commented 5 years ago

Upon debugging it seems like the ref isn't getting created in LoadableVisibilityComponent.

My current setup:

tazsingh commented 5 years ago

In the future, please provide a reproducible build. It took me a considerable amount of time to create this Sandbox - https://codesandbox.io/s/us49e

I've pushed a fix. Will be released in 3.0.1.

sauravvarma commented 5 years ago

My apologies, I didn't realise you meant a sample app (I'm fairly new to this) or thought it was going to be tough task reproducing it. I'll definitely provide reproducible sandbox examples for the few bugs I have encountered after this version.

Thank you so much, you've been kind and really helpful.