search

stratiformltd / react-loadable-visibility

A wrapper around react-loadable and @loadable/component to load elements once they are visible on the page.
BSD 3-Clause "New" or "Revised" License
1.01k stars 32 forks source link

Edge fix #6

Closed RobinSiep closed 6 years ago

RobinSiep commented 6 years ago

Hi,

Since a couple of months Edge supports the Intersection Observer which is of course great news. However the Intersection Observer implementation in Edge requires the target element to have a height and width of at least 1px as discussed here on Stack Overflow.

tazsingh commented 6 years ago

Thanks for this!

As seems to be the theme with me lately, I’m traveling and don’t have access to my computer to review and merge. Will have a look on Monday when I’m back in front of it.

Sent from my iPhone

On Oct 20, 2017, at 12:36 AM, Robin Siep notifications@github.com wrote:

Hi,

Since a couple of months Edge supports the Intersection Observer which is of course great news. However the Intersection Observer implementation in Edge requires the target element to have a height and width of at least 1px as discussed here on Stack Overflow. As the post mentions, if the target element doesn't meet this requirement the callback doesn't get fired.

You can view, comment on, or merge this pull request online at:

https://github.com/stratiformltd/react-loadable-visibility/pull/6

Commit Summary

Edge fix File Changes

M src/createLoadableVisibilityComponent.js (4) Patch Links:

https://github.com/stratiformltd/react-loadable-visibility/pull/6.patch https://github.com/stratiformltd/react-loadable-visibility/pull/6.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

RobinSiep commented 6 years ago

Sounds good, no rush ;)

tazsingh commented 6 years ago

Merged and published as v2.4.2 :)

RobinSiep commented 6 years ago

Great news, thanks for the fast response!