stratigraphic / phaser-app

GitHub pages repository to host the PHASER application
2 stars 0 forks source link

Sitecode not showing in sitecode box on Datings tab (or SG, G P tabs) #36

Closed Keith-May closed 2 years ago

cbinding commented 2 years ago

Site codes display where they are present in the data, see following examples (from THM CSV data):

Context: image

Subgroup: image

Group: image

Can you clarify which records you are referring to so we can investigate further (i.e. data file(s) imported/loaded and specific ID(s) of item(s) where site code is not displaying correctly)

Keith-May commented 2 years ago

does reflect perhaps a need to keep a version number somewhere in the Metadata so that a saved JSON file includes the Phaser Version it was created with? By which I meant can it auto-populate the version number in the Metadata when we save to JSON? Best K

AHRC Leadership Fellow – The Matrixhttps://www.researchgate.net/project/The-Matrix-connecting-and-re-using-digital-records-and-archives-of-archaeological-investigations?_sg=alaJc57bvwRBeZpJg3BQN5vf-_twsBDNSxp8O7hvb3Aex3dlZhjgKxoiCLQ3Q4-_fSgTz7QoHF65t3_ygfdIiA4mGSpBbCOV70Xr Analytics Department Policy & Evidence Historic England Mobile: 07585 034315 May, K. 2020 The Matrix: Connecting Time and Space in Archaeological Stratigraphic Records and Archives, Internet Archaeology 55. https://doi.org/10.11141/ia.55.8 The Matrix project web page: https://stratigraphic.github.io/matrix/

[Historic England Logo]http://www.historicengland.org.uk/

Work with us to champion heritage and improve lives. Read our Future Strategy and get involved at historicengland.org.uk/strategyhttp://historicengland.org.uk/strategy. Follow us: Facebookhttps://www.facebook.com/HistoricEngland | Twitterhttps://twitter.com/HistoricEngland | Instagramhttps://www.instagram.com/historicengland/ Sign up to our newsletterhttp://webmail.historicenglandservices.org.uk/k/Historic-England/historic_england_preference_centre

This e-mail (and any attachments) is confidential and may contain personal views which are not the views of Historic England unless specifically stated. If you have received it in error, please delete it from your system and notify the sender immediately. Do not use, copy or disclose the information in any way nor act in reliance on it. Any information sent to Historic England may become publicly available. We respect your privacy and the use of your information. Please read our full privacy policyhttps://www.historicengland.org.uk/terms/privacy-cookies/ for more information.

From: May, Keith Sent: 25 March 2022 12:38 To: stratigraphic/phaser-app @.***> Subject: RE: [stratigraphic/phaser-app] Sitecode not showing in sitecode box on Datings tab (or SG, G P tabs) (Issue #36)

OK Ceri,

I think it could be because I was using a (relatively) old version of data from XSM10 (file from pre-Christmas) to illustrate importing Periods for the video capture for my SAA slide. I had to use an old JSON file because all the newer saved files tend to have the Periods already imported.

So hopefully not a problem – although does reflect perhaps a need to keep a version number somewhere in the Metadata so that a saved JSON file includes the Phaser Version it was created with?

Cheers K

AHRC Leadership Fellow – The Matrixhttps://www.researchgate.net/project/The-Matrix-connecting-and-re-using-digital-records-and-archives-of-archaeological-investigations?_sg=alaJc57bvwRBeZpJg3BQN5vf-_twsBDNSxp8O7hvb3Aex3dlZhjgKxoiCLQ3Q4-_fSgTz7QoHF65t3_ygfdIiA4mGSpBbCOV70Xr Analytics Department Policy & Evidence Historic England Mobile: 07585 034315 May, K. 2020 The Matrix: Connecting Time and Space in Archaeological Stratigraphic Records and Archives, Internet Archaeology 55. https://doi.org/10.11141/ia.55.8 The Matrix project web page: https://stratigraphic.github.io/matrix/

From: Ceri Binding @.**@.>> Sent: 25 March 2022 12:22 To: stratigraphic/phaser-app @.**@.>> Cc: May, Keith @.**@.>>; Author @.**@.>> Subject: Re: [stratigraphic/phaser-app] Sitecode not showing in sitecode box on Datings tab (or SG, G P tabs) (Issue #36)

THIS IS AN EXTERNAL EMAIL: do not click any links or open any attachments unless you trust the sender and were expecting the content to be sent to you

Site codes display where they are present in the data, see following examples (from THM CSV data):

Context: [image]https://user-images.githubusercontent.com/274553/160119034-a6ac3328-eb38-406d-a0ae-616d3f54faab.png

Subgroup: [image]https://user-images.githubusercontent.com/274553/160119118-6572637c-3cdd-4600-9144-0032ac517412.png

Group: [image]https://user-images.githubusercontent.com/274553/160119284-0a1e9d38-b894-4850-8e5a-d773c739b8ee.png

Can you clarify which records you are referring to so we can investigate further (i.e. data file(s) imported/loaded and specific ID(s) of item(s) where site code is not displaying correctly)

— Reply to this email directly, view it on GitHubhttps://github.com/stratigraphic/phaser-app/issues/36#issuecomment-1078977629, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH7XKB7T4TCOD5DLWIFWIIDVBWVW5ANCNFSM5RT55VJA. You are receiving this because you authored the thread.Message ID: @.**@.>>

Keith-May commented 2 years ago

OK Ceri,

I think it could be because I was using a (relatively) old version of data from XSM10 (file from pre-Christmas) to illustrate importing Periods for the video capture for my SAA slide. I had to use an old JSON file because all the newer saved files tend to have the Periods already imported.

So hopefully not a problem – although does reflect perhaps a need to keep a version number somewhere in the Metadata so that a saved JSON file includes the Phaser Version it was created with?

Cheers K

AHRC Leadership Fellow – The Matrixhttps://www.researchgate.net/project/The-Matrix-connecting-and-re-using-digital-records-and-archives-of-archaeological-investigations?_sg=alaJc57bvwRBeZpJg3BQN5vf-_twsBDNSxp8O7hvb3Aex3dlZhjgKxoiCLQ3Q4-_fSgTz7QoHF65t3_ygfdIiA4mGSpBbCOV70Xr Analytics Department Policy & Evidence Historic England Mobile: 07585 034315 May, K. 2020 The Matrix: Connecting Time and Space in Archaeological Stratigraphic Records and Archives, Internet Archaeology 55. https://doi.org/10.11141/ia.55.8 The Matrix project web page: https://stratigraphic.github.io/matrix/

From: Ceri Binding @.> Sent: 25 March 2022 12:22 To: stratigraphic/phaser-app @.> Cc: May, Keith @.>; Author @.> Subject: Re: [stratigraphic/phaser-app] Sitecode not showing in sitecode box on Datings tab (or SG, G P tabs) (Issue #36)

THIS IS AN EXTERNAL EMAIL: do not click any links or open any attachments unless you trust the sender and were expecting the content to be sent to you

Site codes display where they are present in the data, see following examples (from THM CSV data):

Context: [image]https://user-images.githubusercontent.com/274553/160119034-a6ac3328-eb38-406d-a0ae-616d3f54faab.png

Subgroup: [image]https://user-images.githubusercontent.com/274553/160119118-6572637c-3cdd-4600-9144-0032ac517412.png

Group: [image]https://user-images.githubusercontent.com/274553/160119284-0a1e9d38-b894-4850-8e5a-d773c739b8ee.png

Can you clarify which records you are referring to so we can investigate further (i.e. data file(s) imported/loaded and specific ID(s) of item(s) where site code is not displaying correctly)

— Reply to this email directly, view it on GitHubhttps://github.com/stratigraphic/phaser-app/issues/36#issuecomment-1078977629, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH7XKB7T4TCOD5DLWIFWIIDVBWVW5ANCNFSM5RT55VJA. You are receiving this because you authored the thread.Message ID: @.**@.>>

[Historic England Logo]http://www.historicengland.org.uk/

Work with us to champion heritage and improve lives. Read our Future Strategy and get involved at historicengland.org.uk/strategyhttp://historicengland.org.uk/strategy. Follow us: Facebookhttps://www.facebook.com/HistoricEngland | Twitterhttps://twitter.com/HistoricEngland | Instagramhttps://www.instagram.com/historicengland/ Sign up to our newsletterhttp://webmail.historicenglandservices.org.uk/k/Historic-England/historic_england_preference_centre

This e-mail (and any attachments) is confidential and may contain personal views which are not the views of Historic England unless specifically stated. If you have received it in error, please delete it from your system and notify the sender immediately. Do not use, copy or disclose the information in any way nor act in reliance on it. Any information sent to Historic England may become publicly available. We respect your privacy and the use of your information. Please read our full privacy policyhttps://www.historicengland.org.uk/terms/privacy-cookies/ for more information.