stratis-storage / project

A holding place for issues that affect more than one repository in the project
4 stars 0 forks source link

Include an rpminspect.yaml file in the next Fedora release #447

Closed mulkieran closed 2 years ago

mulkieran commented 2 years ago

Notes:

Related: #446

Prior steps:

  1. We will run rpminspect on 2 koji builds that represent different upstream releases, 3.0.3-1 and 3.0.4-1. I do not yet understand how to make rpminspect do this, but it is possible.
  2. We will scrutinize the resulting errors on one system, and choose carefully what we can ignore.

NOTE: It turns out that 3.0.3-1 koji builds are all missing, too old. We'll have to skip this step. The best we can do is run on an early and a late version of 3.0.4, which is not that useful.

koji ids compared are: 84177931 and 84863015.

Plan:

  1. We will make a Fedora release, without an rpminspect.yaml.
  2. We will check the rmpinspect results. We will unpush the release if we can.
  3. We will make an rpminspect.yaml file based on our observations from steps (1) and (2) and using the examples above. If annocheck is being run in a context where it is invoked using the wrong debuginfo files we will exclude it altogether.
mulkieran commented 2 years ago

Proposed rpminspect.yaml for stratisd:

inspections:
  # none of our compiled code has an ABI
  abidiff: off
  # at present the wrong debuginfo files are being used to run this check
  annocheck: off
  # the project does not use .desktop files
  desktop: off
  # the project uses no Java
  javabytecode: off

# The info is fine, but we'll assume that all the filesize changes are as intended.
filesize: info
rpmdeps:
  # ignore auto dependencies like: (crate(bindgen/default) >= 0.59.0 with crate(bindgen/default) < 0.60.0~)'
  requires: ^\(crate\(.*\) >= .* with crate\(.*\) < .*\)$

Proposed rpminspect.yaml for stratis-cli:

inspections:
  # stratis-cli has no ABI
  abidiff: off
  # stratis-cli is a Python program
  annocheck: off
  # the project does not use .desktop files
  desktop: off
  # stratis-cli is a Python program
  elf: off
  # the project uses no Java
  javabytecode: off
  # stratis-cli is a Python program
  lto: off

# The info is fine, but we'll assume that all the filesize changes are as intended.
filesize: info
mulkieran commented 2 years ago

I'm closing this. We've committed our proposed changes to ci, and have begun incorporating them into our Fedora releases.