Snapshot support - Githubissues

stratis-storage / stratis-cli

CLI for the Stratis project

https://stratis-storage.github.io

Apache License 2.0

106 stars 20 forks source link

Snapshot support #1100

Closed mulkieran closed 1 month ago

mulkieran commented 2 months ago

Expect test failures

mulkieran commented 2 months ago

Expect all tests to pass

mulkieran commented 2 months ago

Really this time...

mulkieran commented 2 months ago

/packit build

packit-as-a-service[bot] commented 2 months ago

Congratulations! One of the builds has completed. :champagne:

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/stratis-storage-stratis-cli-1100
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

mulkieran commented 1 month ago

Overall this looks good. The one thing I noticed in the PR is that we seem to create a new error for every error from the CLI when the D-Bus API returns an Identity result. Is this to specifically tie a good error message to each of these cases? Is there an advantage to not using the same error with different error messages as input? This is unrelated to the PR, but more something I noticed while reviewing this.

I think you're correct, that class inheritance tree looks unnecessarily bushy. We can prune it this autumn.

mulkieran commented 1 month ago

Expecting tests to pass now...