Closed mulkieran closed 1 month ago
Expect test failures
Expect all tests to pass
Really this time...
/packit build
Congratulations! One of the builds has completed. :champagne:
You can install the built RPMs by following these steps:
sudo yum install -y dnf-plugins-core
on RHEL 8sudo dnf install -y dnf-plugins-core
on Fedoradnf copr enable packit/stratis-storage-stratis-cli-1100
Please note that the RPMs should be used only in a testing environment.
Overall this looks good. The one thing I noticed in the PR is that we seem to create a new error for every error from the CLI when the D-Bus API returns an Identity result. Is this to specifically tie a good error message to each of these cases? Is there an advantage to not using the same error with different error messages as input? This is unrelated to the PR, but more something I noticed while reviewing this.
I think you're correct, that class inheritance tree looks unnecessarily bushy. We can prune it this autumn.
Expecting tests to pass now...
Related https://github.com/stratis-storage/stratis-cli/issues/1085