stratis-storage / stratisd

Easy to use local storage management for Linux.
https://stratis-storage.github.io
Mozilla Public License 2.0
795 stars 55 forks source link

Organize metadata discovery and writing code #1781

Open mulkieran opened 4 years ago

mulkieran commented 4 years ago

If we group it together we can keep track of its invariants better. metadata management for a single device has already been grouped into the metadata module. What we're talking about here is metadata discovery when given a group of devices or metadata update on all the devices belonging to a pool.

mulkieran commented 4 years ago

This is related to https://github.com/stratis-storage/stratisd/pull/1779. The assumption in the prior code, that is corrected in the PR, is that failure to locate metadata on a group of devices indicates some kind of problem. But, because the metadata isn't written to all the devices among a large group, it may be the case that failure to get the metadata results from a subset of the devices having been picked up that just do not have metadata written.