search

stratis-storage / stratisd

Easy to use local storage management for Linux.
https://stratis-storage.github.io
Mozilla Public License 2.0
794 stars 55 forks source link

Regression test for key set in stratis-min #3591

Closed jbaublitz closed 5 months ago

jbaublitz commented 5 months ago

Related to #3588

mulkieran commented 5 months ago

@jbaublitz Just noting that stratis-min does not do password verification, only stratis-cli. As far as I'm concerned, the test is fine, but the input string makes it look like you expect the password to be read twice.

jbaublitz commented 5 months ago

We should maybe consider doing password verification, but that seems low priority.

mulkieran commented 5 months ago

@jbaublitz Please rebase when convenient.

mulkieran commented 5 months ago

We should maybe consider doing password verification, but that seems low priority.

Yes, we should. I filed an issue: https://github.com/stratis-storage/stratisd/issues/3593 .