search

stratis-storage / stratisd

Easy to use local storage management for Linux.
https://stratis-storage.github.io
Mozilla Public License 2.0
793 stars 56 forks source link

Start running metadata verification post-test checks #3618

Closed mulkieran closed 3 months ago

mulkieran commented 3 months ago

Related https://github.com/stratis-storage/project/issues/710

mulkieran commented 3 months ago

Trivial unless it fails

packit-as-a-service[bot] commented 3 months ago

Cockpit tests failed for commit 05f1502a5e756e5d7d8406c6f05f23b88cdeee7e. @martinpitt, @jelly, @mvollmer please check.

mulkieran commented 3 months ago

Probably an anomalous failure for us...would be nice to improve test framework to give us a bit more, though.

mulkieran commented 3 months ago

We should be retrying on the problem below:

  File "/var/ARTIFACTS/work-allf74mxjuq/plans/all/discover/default-0/tests/tests/client-dbus/tests/udev/test_udev.py", line 299, in test_encryption_simple_initial_discovery_with_takedown
    self._simple_initial_discovery_test(
  File "/var/ARTIFACTS/work-allf74mxjuq/plans/all/discover/default-0/tests/tests/client-dbus/tests/udev/test_udev.py", line 256, in _simple_initial_discovery_test
    wait_for_udev(STRATIS_FS_TYPE, get_devnodes(device_object_paths))
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/var/ARTIFACTS/work-allf74mxjuq/plans/all/discover/default-0/tests/tests/client-dbus/tests/udev/_utils.py", line 138, in get_devnodes
    Blockdev.Properties.Devnode.Get(get_object(op)) for op in device_object_paths
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/dbus_python_client_gen/_invokers.py", line 79, in dbus_func
    raise DPClientInvocationError(
dbus_python_client_gen._errors.DPClientInvocationError: Error while getting value for property "Devnode" belonging to interface "org.storage.stratis3.blockdev.r7"

not failing, since it is almost certainly just caused by not getting object paths on the D-Bus quite fast enough.

mulkieran commented 3 months ago

Blocked by https://github.com/stratis-storage/testing/pull/259

mulkieran commented 3 months ago

rebased

mulkieran commented 3 months ago

We expect the tests to pass.