search

stratis-storage / stratisd

Easy to use local storage management for Linux.
https://stratis-storage.github.io
Mozilla Public License 2.0
793 stars 56 forks source link

Add optional merge field to FilesystemSave metadata #3623

Open mulkieran opened 3 months ago

mulkieran commented 3 months ago

Related https://github.com/stratis-storage/stratisd/issues/3621

packit-as-a-service[bot] commented 1 month ago

Cockpit tests failed for commit 017f3309c9771120700ae2b2e0142a8fb115dc83. @martinpitt, @jelly, @mvollmer please check.

martinpitt commented 1 month ago

Ech, can we please stop breaking rawhide in new an "interesting" ways every censored day? I'm still catching up with the fallout from the firewalld/selinux debacle..

+ chpasswd
chpasswd: (user root) pam_chauthtok() failed, error:
Authentication token manipulation error
chpasswd: (line 1, user root) password not changed

Again, clearly not your fault. I'm still busy with investigating/reporting the other regressions from last night, so if someone else could have a look that'd be nice. However, as #3653 went green, it's worth retrying.

martinpitt commented 1 month ago

The timing coincides with https://bodhi.fedoraproject.org/updates/FEDORA-2024-26a844bb1c . This also happens in podman PRs, e.g. https://github.com/containers/podman/pull/23274 or https://github.com/containers/podman/pull/23275 .

Trivially reproducible in a rawhide VM with updating shadow-utils. With shadow-utils-2:4.15.1-8.fc41.x86_64 (not the latest version from that bodhi update, that's -9):

# echo root:foobar | chpasswd
chpasswd: (user root) pam_chauthtok() failed, error:
Authentication token manipulation error
chpasswd: (line 1, user root) password not changed

That most recent bodhi update reverted the change again:

dnf update https://kojipkgs.fedoraproject.org//packages/shadow-utils/4.15.1/9.fc41/x86_64/shadow-utils-4.15.1-9.fc41.x86_64.rpm

and with that it works. So please retry.

packit-as-a-service[bot] commented 1 month ago

Cockpit tests failed for commit e5933bacf870f7cecd3492faaf94fc213b91e033. @martinpitt, @jelly, @mvollmer please check.

martinpitt commented 1 month ago

I hacked around the shadow-utils b0rkage in https://github.com/cockpit-project/cockpit/pull/20802 . Can you please retry the failed tests (or ignore the rawhide failures if you don't care)?

mulkieran commented 2 weeks ago

rebased. This was just a conflict w/ the filesystem metadata PR, so it was not a lot of work to resolve the conflicts.

packit-as-a-service[bot] commented 1 week ago

Cockpit tests failed for commit 7d9664dde32bb13292260825d49aa12c2d58626e. @martinpitt, @jelly, @mvollmer please check.

packit-as-a-service[bot] commented 1 week ago

Cockpit tests failed for commit 03e19a3d9f628bc22649d9f666c58c80ebe00452. @martinpitt, @jelly, @mvollmer please check.

packit-as-a-service[bot] commented 1 week ago

Cockpit tests failed for commit 12a2d195e7e0dd8037466b8c41bfa569e658587f. @martinpitt, @jelly, @mvollmer please check.

mulkieran commented 1 week ago

I think that likely we'll need to expose the message method in devicemapper and that that will be the most efficient and easiest thing.

mulkieran commented 5 days ago

Now running into ENOSPC on both ubuntu and fedora.

mulkieran commented 1 day ago

On both Fedora and Ubuntu, loop_test_rename is just hanging...

mulkieran commented 1 day ago

Huzzah! At least the thinpool checks are succeeding (by reducing the size of the filesystems).

mulkieran commented 1 day ago

Next step is to set the XFS filesystem UUID.