search

stratisproject / StratisBitcoinFullNode

Bitcoin full node in C#
https://stratisplatform.com
MIT License
787 stars 314 forks source link

[Rules] Parent/PowParent/PosParent #2766

Open MithrilMan opened 5 years ago

MithrilMan commented 5 years ago

Our rules have a Parent/PowParent/PosParent property that point to the rule engine they belongs to. The name doesn't communicate that at all.

I propose to rename those property to Parent => RuleEngine PowParent => PowRuleEngine PosParent => PosRuleEngine

dangershony commented 5 years ago

Another thing to refactor is how we handle the ProtocolVersion and the NodeServices enums.

Currently they are mixed together with other networks, we need to find a way to define these enums per networks, perhaps they need to go in to ConsensusFactory or even a NetworkFactory in the network class.