search

stratisproject / StratisBitcoinFullNode

Bitcoin full node in C#
https://stratisplatform.com
MIT License
787 stars 314 forks source link

NBitcoin Refactoring locking thread - announce your locks here #736

Closed Aprogiena closed 6 years ago

Aprogiena commented 6 years ago

This is to communicate which NBitcoin files or whole folders do you want other devs NOT TO TOUCH because you are working on them.

Syntax is simply, either you announce LOCK or you announce UNLOCK. The question is when to unlock, I'd say AFTER your PR is merged, otherwise it would create conflicts.

I'll start with example and the first lock:

LOCK External\NBitcoin\Protocol\Node*.cs except for NodesGroup.cs

fassadlr commented 6 years ago

LOCK External\NBitcoin\Protocol\AddressManager.cs External\NBitcoin\Protocol\AddressManager\Behaviors\AddressManagerBehavior.cs External\NBitcoin\Protocol\AddressManager\Behaviors\NodesGroupBehavior.cs

dangershony commented 6 years ago

LOCK Network.cs Networks.cs NetworkBuilder.cs

Aprogiena commented 6 years ago

@dangershony full path pls :) to avoid confusions

fassadlr commented 6 years ago

@Aprogiena Im just going through my PR, I need to lock

External\NBitcoin\Protocol\Node.cs

too.

Aprogiena commented 6 years ago

@fassadlr you can't lock Node.cs because it is locked :D and my PR is already in the queue, so you will just have conflicts. i'll unlock it as soon as PR is merged

fassadlr commented 6 years ago

All good @Aprogiena I just saw it now :) Its ok I can merge your changes in after.

Aprogiena commented 6 years ago

unlocking my locks: UNLOCK External\NBitcoin\Protocol\Node*.cs except for NodesGroup.cs

dangershony commented 6 years ago

UNLOCK 

Network.cs
Networks.cs
NetworkBuilder.cs
mikedennis commented 6 years ago

LOCK \NBitcoin\ChainedBlock.cs

Aprogiena commented 6 years ago

LOCK

Aprogiena commented 6 years ago

UNLOCK

Aprogiena commented 6 years ago

@mikedennis i guess you could unlock right?

mikedennis commented 6 years ago

UNLOCK \NBitcoin\ChainedBlock.cs

Will be doing more work on this later but for now it's open.

fassadlr commented 6 years ago

UNLOCK External\NBitcoin\Protocol\AddressManager.cs External\NBitcoin\Protocol\AddressManager\Behaviors\AddressManagerBehavior.cs External\NBitcoin\Protocol\AddressManager\Behaviors\NodesGroupBehavior.cs

Aprogiena commented 6 years ago

@fassadlr Node.cs also free now?

fassadlr commented 6 years ago

Ah yes @aprogiena Node.cs is unlocked.

Aprogiena commented 6 years ago

Thank you, in which case I

LOCK

Aprogiena commented 6 years ago

UNLOCK

dangershony commented 6 years ago

Ok I think we can close this right?

Aprogiena commented 6 years ago

good for me to close