strato-emu / strato

Run Nintendo Switch homebrew & games on your Android device!
https://strato-emu.github.io
GNU General Public License v3.0
2.19k stars 277 forks source link

add picture in picture option #243

Closed Ishan09811 closed 9 months ago

QuackingCanary commented 9 months ago

Hi Ishan, we reviewed your PR. That's a good idea but you should instead use an Intent to redirect the user directly to the app (system) settings using startActivity(Intent("android.settings.PICTURE_IN_PICTURE_SETTINGS", Uri.parse("package:${packageName}"))) instead of creating a new setting in Strato

Ishan09811 commented 9 months ago

@QuackingCanary your alternative idea is good but launching a intent to go system settings and manage the picture in picture is weird and time taking process also some people will not understand what is picture in picture and what it does so if we provide a option in the settings then the summary will inform the purpose of the option.

QuackingCanary commented 9 months ago

Screenshot_20240221-171146 You get a brief explanation of what Picture in Picture is when you reach the Intent. The setting is pointless since Android already has a solution

Ishan09811 commented 9 months ago

@QuackingCanary While implementing a custom setting within the app can offer clarity and control,relying on system settings reduces the complexity of app. However, it's essential to consider the user experience and preferences when making this decision, as some users may prefer managing settings directly within the app for convenience and accessibility so we need to talk with users for their suggestions.