create.sh - use of aws-hello-world/reflectoring-hello-world instead of todo-app-v1

stratospheric-dev / stratospheric

All you need to know to get your Spring Boot application into production with AWS 🍃

https://stratospheric.dev

Apache License 2.0

262 stars 187 forks source link

create.sh - use of aws-hello-world/reflectoring-hello-world instead of todo-app-v1 #140

Closed amoffet closed 2 years ago

amoffet commented 2 years ago

What's going wrong and not working?

The book appears to have been modified to use todo-app-v1 (in ecs-basic/create.sh) as the ServiceName parameter and in the imageUrl. The source code has not.

It may also be well to point out that the user may need to change the namespace (from stratospheric) in the book and reflectoring in the code.

Expected outcome

No response

BjoernKW commented 2 years ago

@amoffet Thanks for your feedback and for bringing this up. We'll unify the namespaces with this pull request: https://github.com/stratospheric-dev/stratospheric/pull/141