stratospheric-dev / stratospheric

All you need to know to get your Spring Boot application into production with AWS 🍃
https://stratospheric.dev
Apache License 2.0
265 stars 188 forks source link

Readability: The transparent version of the Stratospheric Technical Architecture Image in the README.md is not readable on a dark mode background. Use the non-transparent image instead #237

Closed shantdashjian closed 1 year ago

shantdashjian commented 1 year ago

User Story:

Description: The transparent version of the Stratospheric Technical Architecture image in the READMe.md is not readable for users with a dark mode GitHub settings.

architecture-image-looks-bad

Steps to Reproduce:

  1. Login to your GitHub.
  2. Make your theme dark mode by changing it in Settings > Appearance.
  3. Visit the stratospheric GitHub repo (this repo).
  4. Scroll down to the section in the README.md where it says "What We're Going to Build.

Current Behavior: The image is transparent and thus the details of the architecture are not easily visible on a dark mode theme background.

Expected Behavior: The details of the technical architecture should be readable on any background.

Fix: Use the non-transparent version of the image rather than the transparent one. This will guarantee the image will look good in all modes. I will submit a PR to fix this issue.

BjoernKW commented 1 year ago

Thanks a lot for bringing this up and for readily providing a pull request. I've just merged your pull request.

shantdashjian commented 1 year ago

Thanks a lot for bringing this up and for readily providing a pull request. I've just merged your pull request.

You're welcome @BjoernKW.