stratospheric-dev / stratospheric

All you need to know to get your Spring Boot application into production with AWS 🍃
https://stratospheric.dev
Apache License 2.0
262 stars 187 forks source link

Inconsistancy - Book contains legacy output declaration for GithubActions #260

Closed TomMannson closed 8 months ago

TomMannson commented 9 months ago

What can we improve?

Hi, I found small inconsistancy between sources and the book Page 123 of the book contains old legacy method for output declaration

echo "::set-output name=tag::$(date +'%Y%m%d%H%M%S')-${GITHUB_SHA}

Maybe It is worth to update the book with new Github Actions recommendations BTW, Sources contain correct output declaration method

Version

2023-10-03

Suggested Changes

According to the Github docs we have new approach for that. New declaration method

echo "tag=$(date +'%Y%m%d%H%M%S')-${GITHUB_SHA}" >> $GITHUB_OUTPUT
BjoernKW commented 8 months ago

Thanks a lot for the suggestion. We'll change that in the next release of the ebook.