Closed szantopeter closed 6 months ago
@rieckpil @BjoernKW Have you had a chance to look at this PR? I made some updates and eventually the login fully works through the loadbalancer
thank you very much for the fixes @szantopeter - In general, we don't maintain the chapter versions anymore as this is a "maintenance hell", but I'm happy to accept your changes to improve our fixes.
So LGTM, @BjoernKW feel free to integrate
Thanks again, @szantopeter! I've just merged your pull request (without the -v2 change for the Docker image name, though; see the comment above).
Thanks for meging and even more for writing the book :) I find it much more valuable to learn through real world scenarios than to spend a lot of time on exam preparation!
Regarding the docker image name I am just unsure what was your original intentions. What happens is that
I was proposing to publish v2, v3 etc images so every chapter can be deployed independently without the need to build a docker image out of it.
Was your plan that everyone have to build their own docker image?
Was your plan that everyone have to build their own docker image?
Essentially, yes. This particularly applies to the chapter versions of the application, which are to be understood as intermediate steps to the final result.
if that was the intention then maybe it would be better reflected by having something like this in the cdk.json
"dockerImageUrl": "build this chapter and place your docker image URL here",
instead of
"dockerImageUrl": "docker.io/stratospheric/todo-app-v1:latest",
that deploys a wrong application. Though I am still not sure what is the value of everyone having to build the image for themselves, but I am fine either way. (I already build and pushed my images :) )
I tried to deploy chapter 10 to my AWS account, but the application wasn't working for multiple reasons