stratum-mining / stratum

stratum
https://stratumprotocol.org
Other
221 stars 127 forks source link

Need Rust docs on `protocols::v2::sv2-ffi` #1015

Open rrybarczyk opened 4 months ago

rrybarczyk commented 4 months ago

Background

Currently, the protocols::v2::sv2-ffi logic does not contain any in-line rust documentation, resulting in no documentation on its crates.io site.

Note: While this issue addresses the need for doc comments, it will also serve as a means to identify code debt that needs to be cleaned up and addressed in future issues.

Problem

When a user navigates to this crate crates.io, there is no useful information for the user. This impedes understanding and adoption.

Solution

Navigate through each crate in protocols::v2::sv2-ffi and add:

While this work is being performed, specific code debt should be looked for and recorded to turn into future issues

Shourya742 commented 1 month ago

@rrybarczyk May I take this on? I would like to explore FFI binding in Rust.

rrybarczyk commented 1 month ago

Added you as an assignee.

Fi3 commented 1 month ago

@Shourya742 take a look at this https://github.com/stratum-mining/stratum/blob/main/examples/interop-cpp/README.md before starting

rrybarczyk commented 4 weeks ago

We are going to deprioritize docs on sv2-ffi because this crate does not have complete functionality (see #919) and the other protocols/ crates should be prioritized as they are more critical.