search

stratum-mining / stratum

stratum
https://stratumprotocol.org
Other
206 stars 122 forks source link

Add fmt an clippy as git hook for commit #1073

Closed Fi3 closed 1 week ago

Fi3 commented 1 month ago

Before committing is very useful to always have fmt and clippy executed so we avoid to have the git log full of fmt and clippy and git blame is more likely to point to the right commit.

xyephy commented 1 month ago

@Fi3 Should I place the pre-commit file under the .githooks directory?

xyephy commented 1 month ago

@Fi3 Should I place the pre-commit file under the .githooks directory?

I'm also getting some errors related to #1048

Shourya742 commented 1 month ago

Hey @xyephy, there’s already an ongoing PR for this issue: https://github.com/stratum-mining/stratum/pull/1039

xyephy commented 1 month ago

Hey @xyephy, there’s already an ongoing PR for this issue: #1039

Thanks for the heads up @Shourya742 , will have a look at it.

GitGab19 commented 1 week ago

Closing this as addressed by https://github.com/stratum-mining/stratum/pull/1039