search

stratum-mining / stratum

stratum
https://stratumprotocol.org
Other
207 stars 122 forks source link

Cleanup cargo build warnings #1096

Open jbesraa opened 1 month ago

jbesraa commented 1 month ago

Handle warnings generated when running cargo build, preferably in an incremental way with separate commit for each set of warnings

rrybarczyk commented 1 month ago

The warnings I see that need to be addressed are:

  1. Cargo.toml unused manifest keys. Do we just delete the lines causing the warning? Then we lose metadata. Is there a way to properly suppress these warnings? What are best practices here?
  2. Code/logic warnings like roles-utils/rpc/src/lib.rs:8:19 and jd-client/src/lib/error.rs:31:5
Arshia-r-m commented 3 weeks ago

Are these warnings generate with every cargo build or just the initial one?

rrybarczyk commented 1 week ago

Are these warnings generate with every cargo build or just the initial one?

Every cargo build. It is quite annoying.

Arshia-r-m commented 1 week ago

I want to work on this issue, I will put the updates on following comments

jbesraa commented 1 week ago

sure, go for it