stratum-mining / stratum

stratum
https://stratumprotocol.org
Other
208 stars 124 forks source link

Update binary-sv2/no-serde-sv2 excport EncodablePrimitive #1118

Closed Fi3 closed 1 month ago

Fi3 commented 1 month ago

In order to implement Encodable (aka Serialize) for sv2 type defined by extensions EncodablePrimitive is needed.

github-actions[bot] commented 1 month ago

🐰Bencher

ReportMon, August 19, 2024 at 18:10:14 UTC
ProjectStratum v2 (SRI)
BranchExportEncodablePrimitive
Testbedsv1

🚨 4 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
serialize_deserialize_authorizeRAM Accesses (accesses)🚨 (view plot | view alert)299.00 (+1.43%)297.88 (100.37%)
serialize_deserialize_handle_subscribeRAM Accesses (accesses)🚨 (view plot | view alert)390.00 (+1.11%)389.07 (100.24%)
serialize_deserialize_subscribeRAM Accesses (accesses)🚨 (view plot | view alert)324.00 (+1.70%)322.14 (100.58%)
serialize_subscribeRAM Accesses (accesses)🚨 (view plot | view alert)161.00 (+3.64%)160.64 (100.22%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,541.00 (+1.33%)8,748.00 (97.63%)✅ (view plot)3,772.00 (+0.90%)3,864.85 (97.60%)✅ (view plot)5,296.00 (+1.01%)5,414.07 (97.82%)✅ (view plot)5.00 (-36.10%)10.53 (47.49%)✅ (view plot)92.00 (+2.32%)94.29 (97.58%)
get_submit✅ (view plot)95,718.00 (+0.18%)96,175.71 (99.52%)✅ (view plot)59,522.00 (+0.09%)59,782.21 (99.56%)✅ (view plot)85,498.00 (+0.11%)85,841.43 (99.60%)✅ (view plot)49.00 (-10.99%)62.54 (78.35%)✅ (view plot)285.00 (+1.11%)288.85 (98.67%)
get_subscribe✅ (view plot)8,102.00 (+1.62%)8,301.93 (97.59%)✅ (view plot)2,848.00 (+0.75%)2,949.78 (96.55%)✅ (view plot)3,982.00 (+0.82%)4,112.47 (96.83%)✅ (view plot)12.00 (-25.65%)19.89 (60.34%)✅ (view plot)116.00 (+2.99%)117.48 (98.74%)
serialize_authorize✅ (view plot)12,392.00 (+1.54%)12,537.73 (98.84%)✅ (view plot)5,343.00 (+0.63%)5,435.85 (98.29%)✅ (view plot)7,457.00 (+0.69%)7,577.17 (98.41%)✅ (view plot)7.00 (-34.37%)13.60 (51.48%)✅ (view plot)140.00 (+3.27%)140.86 (99.39%)
serialize_deserialize_authorize✅ (view plot)24,670.00 (+0.83%)24,728.25 (99.76%)✅ (view plot)9,950.00 (+0.51%)10,035.49 (99.15%)✅ (view plot)14,050.00 (+0.59%)14,163.84 (99.20%)✅ (view plot)31.00 (-15.25%)41.76 (74.24%)🚨 (view plot | view alert)299.00 (+1.43%)297.88 (100.37%)
serialize_deserialize_handle_authorize✅ (view plot)30,270.00 (+0.44%)30,374.89 (99.65%)✅ (view plot)12,127.00 (+0.28%)12,219.85 (99.24%)✅ (view plot)17,165.00 (+0.29%)17,291.71 (99.27%)✅ (view plot)59.00 (+0.30%)64.71 (91.18%)✅ (view plot)366.00 (+0.66%)367.22 (99.67%)
serialize_deserialize_handle_submit✅ (view plot)126,605.00 (+0.16%)127,078.57 (99.63%)✅ (view plot)73,307.00 (+0.08%)73,628.21 (99.56%)✅ (view plot)105,095.00 (+0.10%)105,523.81 (99.59%)✅ (view plot)109.00 (-9.13%)131.89 (82.64%)✅ (view plot)599.00 (+0.74%)600.48 (99.75%)
serialize_deserialize_handle_subscribe✅ (view plot)27,614.00 (+0.60%)27,648.92 (99.87%)✅ (view plot)9,650.00 (+0.22%)9,751.78 (98.96%)✅ (view plot)13,649.00 (+0.22%)13,787.92 (98.99%)✅ (view plot)63.00 (-4.49%)73.66 (85.52%)🚨 (view plot | view alert)390.00 (+1.11%)389.07 (100.24%)
serialize_deserialize_submit✅ (view plot)115,367.00 (+0.25%)115,682.45 (99.73%)✅ (view plot)68,167.00 (+0.15%)68,409.59 (99.65%)✅ (view plot)97,842.00 (+0.19%)98,163.15 (99.67%)✅ (view plot)61.00 (-12.09%)75.70 (80.58%)✅ (view plot)492.00 (+0.84%)493.39 (99.72%)
serialize_deserialize_subscribe✅ (view plot)23,088.00 (+0.94%)23,142.71 (99.76%)✅ (view plot)8,209.00 (+0.32%)8,307.33 (98.82%)✅ (view plot)11,563.00 (+0.32%)11,695.49 (98.87%)✅ (view plot)37.00 (-6.22%)43.98 (84.12%)🚨 (view plot | view alert)324.00 (+1.70%)322.14 (100.58%)
serialize_submit✅ (view plot)100,125.00 (+0.23%)100,509.12 (99.62%)✅ (view plot)61,566.00 (+0.08%)61,831.38 (99.57%)✅ (view plot)88,345.00 (+0.10%)88,694.81 (99.61%)✅ (view plot)46.00 (-17.39%)62.59 (73.50%)✅ (view plot)330.00 (+1.66%)330.85 (99.74%)
serialize_subscribe✅ (view plot)11,541.00 (+1.89%)11,648.81 (99.07%)✅ (view plot)4,195.00 (+0.51%)4,296.78 (97.63%)✅ (view plot)5,836.00 (+0.48%)5,971.57 (97.73%)✅ (view plot)14.00 (-14.38%)19.04 (73.54%)🚨 (view plot | view alert)161.00 (+3.64%)160.64 (100.22%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
github-actions[bot] commented 1 month ago

🐰Bencher

ReportMon, August 19, 2024 at 18:10:25 UTC
ProjectStratum v2 (SRI)
Branch1118/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,564.80 (-5.35%)7,346.90 (89.35%)
client-submit-serialize-deserialize✅ (view plot)7,445.00 (-5.26%)8,347.64 (89.19%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,017.20 (-4.81%)8,852.10 (90.57%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)921.10 (+2.46%)927.88 (99.27%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)702.43 (+0.76%)717.78 (97.86%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)249.46 (+0.56%)255.16 (97.76%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)156.55 (-0.37%)162.35 (96.43%)
client-sv1-get-submit✅ (view plot)6,352.00 (-5.21%)7,142.82 (88.93%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)282.53 (+1.39%)291.22 (97.02%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)764.69 (+2.30%)776.76 (98.45%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)604.40 (-1.58%)637.34 (94.83%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)206.61 (-0.07%)219.87 (93.97%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
github-actions[bot] commented 1 month ago

🐰Bencher

ReportMon, August 19, 2024 at 18:10:30 UTC
ProjectStratum v2 (SRI)
BranchExportEncodablePrimitive
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.05 (-1.11%)45.23 (97.39%)
client_sv2_handle_message_mining✅ (view plot)75.48 (+3.24%)81.06 (93.12%)
client_sv2_mining_message_submit_standard✅ (view plot)14.64 (-0.06%)14.69 (99.66%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)275.63 (+4.20%)283.99 (97.06%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)592.40 (-0.28%)626.96 (94.49%)
client_sv2_open_channel✅ (view plot)164.38 (-0.76%)171.38 (95.92%)
client_sv2_open_channel_serialize✅ (view plot)280.22 (-1.00%)293.56 (95.46%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)368.74 (-2.48%)422.90 (87.19%)
client_sv2_setup_connection✅ (view plot)160.09 (-2.51%)174.89 (91.54%)
client_sv2_setup_connection_serialize✅ (view plot)439.71 (-7.15%)505.78 (86.94%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)980.88 (+0.85%)1,043.49 (94.00%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
github-actions[bot] commented 1 month ago

🐰Bencher

ReportMon, August 19, 2024 at 18:10:33 UTC
ProjectStratum v2 (SRI)
BranchExportEncodablePrimitive
Testbedsv2

🚨 10 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonL2 Accesses (accesses)🚨 (view plot | view alert)12.00 (+72.31%)10.80 (111.14%)
client_sv2_mining_message_submit_standardL2 Accesses (accesses)🚨 (view plot | view alert)23.00 (+31.16%)22.72 (101.24%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,591.00 (+0.45%)10,568.85 (100.21%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)15,405.00 (+0.42%)15,374.65 (100.20%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,027.00 (+0.53%)8,009.32 (100.22%)
client_sv2_open_channel_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)11,668.00 (+0.45%)11,646.54 (100.18%)
client_sv2_open_channel_serialize_deserializeL2 Accesses (accesses)🚨 (view plot | view alert)85.00 (+15.59%)82.57 (102.95%)
client_sv2_setup_connectionL2 Accesses (accesses)🚨 (view plot | view alert)14.00 (+53.42%)13.75 (101.85%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,855.00 (+0.29%)14,836.63 (100.12%)
client_sv2_setup_connection_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)21,814.00 (+0.29%)21,784.99 (100.13%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,119.00 (+3.23%)2,135.41 (99.23%)✅ (view plot)473.00 (+0.47%)486.21 (97.28%)✅ (view plot)729.00 (-0.44%)754.92 (96.57%)🚨 (view plot | view alert)12.00 (+72.31%)10.80 (111.14%)✅ (view plot)38.00 (+3.45%)38.78 (97.99%)
client_sv2_handle_message_mining✅ (view plot)8,251.00 (+0.65%)8,335.65 (98.98%)✅ (view plot)2,143.00 (+0.71%)2,171.53 (98.69%)✅ (view plot)3,166.00 (+0.65%)3,216.28 (98.44%)✅ (view plot)37.00 (-3.58%)43.51 (85.05%)✅ (view plot)140.00 (+0.81%)141.96 (98.62%)
client_sv2_mining_message_submit_standard✅ (view plot)6,344.00 (+1.06%)6,391.67 (99.25%)✅ (view plot)1,756.00 (+0.36%)1,763.40 (99.58%)✅ (view plot)2,554.00 (+0.00%)2,575.68 (99.16%)🚨 (view plot | view alert)23.00 (+31.16%)22.72 (101.24%)✅ (view plot)105.00 (+1.08%)106.93 (98.19%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,809.00 (+0.19%)15,034.35 (98.50%)✅ (view plot)4,700.00 (+0.13%)4,707.40 (99.84%)✅ (view plot)6,759.00 (+0.07%)6,775.15 (99.76%)✅ (view plot)49.00 (+3.82%)51.67 (94.84%)✅ (view plot)223.00 (+0.18%)229.95 (96.98%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,595.00 (+0.40%)27,849.01 (99.09%)🚨 (view plot | view alert)10,591.00 (+0.45%)10,568.85 (100.21%)🚨 (view plot | view alert)15,405.00 (+0.42%)15,374.65 (100.20%)✅ (view plot)86.00 (+2.75%)89.15 (96.47%)✅ (view plot)336.00 (+0.30%)345.31 (97.31%)
client_sv2_open_channel✅ (view plot)4,361.00 (-2.90%)4,616.63 (94.46%)✅ (view plot)1,461.00 (+0.05%)1,474.22 (99.10%)✅ (view plot)2,156.00 (+0.15%)2,172.59 (99.24%)✅ (view plot)14.00 (+16.15%)15.29 (91.54%)✅ (view plot)61.00 (-6.28%)68.40 (89.18%)
client_sv2_open_channel_serialize✅ (view plot)14,080.00 (-0.98%)14,457.01 (97.39%)✅ (view plot)5,064.00 (+0.02%)5,077.22 (99.74%)✅ (view plot)7,325.00 (+0.10%)7,339.15 (99.81%)✅ (view plot)35.00 (-5.63%)41.38 (84.59%)✅ (view plot)188.00 (-2.02%)198.73 (94.60%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,663.00 (+0.07%)23,024.14 (98.43%)🚨 (view plot | view alert)8,027.00 (+0.53%)8,009.32 (100.22%)🚨 (view plot | view alert)11,668.00 (+0.45%)11,646.54 (100.18%)🚨 (view plot | view alert)85.00 (+15.59%)82.57 (102.95%)✅ (view plot)302.00 (-0.88%)314.85 (95.92%)
client_sv2_setup_connection✅ (view plot)4,689.00 (-0.23%)4,765.51 (98.39%)✅ (view plot)1,502.00 (+0.05%)1,515.22 (99.13%)✅ (view plot)2,274.00 (-0.12%)2,299.33 (98.90%)🚨 (view plot | view alert)14.00 (+53.42%)13.75 (101.85%)✅ (view plot)67.00 (-1.37%)69.61 (96.25%)
client_sv2_setup_connection_serialize✅ (view plot)16,180.00 (-0.57%)16,483.54 (98.16%)✅ (view plot)5,963.00 (+0.01%)5,976.22 (99.78%)✅ (view plot)8,655.00 (+0.00%)8,676.83 (99.75%)✅ (view plot)49.00 (+9.37%)49.46 (99.06%)✅ (view plot)208.00 (-1.55%)217.21 (95.76%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,554.00 (+0.04%)35,750.15 (99.45%)🚨 (view plot | view alert)14,855.00 (+0.29%)14,836.63 (100.12%)🚨 (view plot | view alert)21,814.00 (+0.29%)21,784.99 (100.13%)✅ (view plot)102.00 (+2.31%)112.45 (90.71%)✅ (view plot)378.00 (-0.46%)384.38 (98.34%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help