Closed Fi3 closed 2 weeks ago
Hi @Fi3 can I give this a try?
sure @xyephy
@xyephy please work on top of this https://github.com/stratum-mining/stratum/pull/1049
@xyephy please work on top of this #1049
Noted.
In my opinion. the channel-bit should be the most significant bit in the extension_type field. That means in the serialized form it should be the 15'th bit counted from zero. It's because we use little-endian representation.
This means, I probably disagree with the proposed change.
@jakubtrnka is right we can close this issue 0b1000_0000_0000_0000 already set the most significant bit. @xyephy
This function in framing_sv2::framing:
Set the bit 0 as channel bit. But spec say that have to be bit 15, 0-indexed, https://github.com/stratum-mining/sv2-spec/blob/main/03-Protocol-Overview.md#32-framing.
The below function should fix the issue