stratum-mining / stratum

stratum
https://stratumprotocol.org
Other
224 stars 129 forks source link

custom logger #1200

Open plebhash opened 1 month ago

plebhash commented 1 month ago

background

protocols crates should use as little external dependencies as possible.

problem

currently, the following crates use tracing as an external dependency:

solution

write a custom logger to replace tracing

reference from rust-lightning: https://github.com/lightningdevkit/rust-lightning/blob/f94bf9861289ce6a75fd7d5856d736a2f966a619/lightning/src/util/logger.rs#L165

Fi3 commented 1 month ago

tracing is kinda of the standard for logging, every project that will use the library will very likely expect to have log reported by tracing, is also audited by google. https://github.com/google/rust-crate-audits/blob/main/manual-sources/google3-audits.toml#L1383

I don't think that we should remove it, if there is a way to do that without disrupting the user experience could make sense. If not no.

Shourya742 commented 4 days ago

https://carbonated-machine-4e3.notion.site/Custom-Logger-878dbdf54d154ad68890c98814df707c