stratum-mining / stratum

stratum
https://stratumprotocol.org
Other
202 stars 120 forks source link

mining-proxy needs graceful death instead of panic #484

Closed bcral closed 1 month ago

bcral commented 1 year ago

The mining-proxy seems to be panicking on closure. This makes test coverage data impossible to retrieve with llvm-cov.

This same issue used to exist on the pool and TProxy until it was fixed by #432

bcral commented 1 year ago

Please tag as "good first issue"!

Priceless-P commented 1 year ago

@bcral i’d like to work on this.

Priceless-P commented 1 year ago

@bcral Just to be sure, this is the file that needs to be worked on for this issue right?

bcral commented 1 year ago

@Priceless-P Yes, that's correct. You may want to check with @darricksee first - he may have already started on this.

darricksee commented 1 year ago

I haven't and probably won't get to it soon.

darricksee commented 1 year ago

Just a heads-up @Priceless-P - to implement this the status-channel also needs to be added to the mining-proxy before getting to this issue. You can certainly add both with this issue - take a look at how the status-channel is used in the pool role. It's basically a mechanism for the application to signal the main thread to terminate if one of the tasks has an error.

Priceless-P commented 1 year ago

Okay. Thank you for letting me know. @darricksee

SumantxD commented 1 year ago

@bcral i would like to work on this issue, can you assign it to me.

Priceless-P commented 1 year ago

Hi @SumantxD, I am currently working on it.

SumantxD commented 1 year ago

@Priceless-P ok fine

mihir1739 commented 1 year ago

Hey is anyone working on this issue ? If not please assign this to me .

pavlenex commented 1 year ago

Hey @mihir1739 it seems @Priceless-P is working on it here https://github.com/stratum-mining/stratum/pull/518

plebhash commented 10 months ago

@Priceless-P what is the status on this? why was #518 closed without being merged?

Priceless-P commented 10 months ago

@plebhash Yes.

johnnyasantoss commented 2 months ago

Is this up for grabs? @Priceless-P