search

stratum-mining / stratum

stratum
https://stratumprotocol.org
Other
204 stars 121 forks source link

refactor: remove generic cases from pool's `handle_error` #777

Open plebhash opened 6 months ago

plebhash commented 6 months ago

as initially discussed on https://github.com/stratum-mining/stratum/issues/773, pool handle_error is too generic:

we should refactor the match e while replacing generic *(_) with specific errors for every possible combination

https://github.com/stratum-mining/stratum/blob/5e36e4581cd6bb153e7379e9e1c44fcfef6fdff1/roles/pool/src/lib/status.rs#L104-L134

NonsoAmadi10 commented 5 months ago

Hello @plebhash , has this issue been done and implemented? It looks like something I can take a go at, what do you think?

plebhash commented 5 months ago

Hello @plebhash , has this issue been done and implemented? It looks like something I can take a go at, what do you think?

it has not, feel free to dive into it!