expand FFI functionality

stratum-mining / stratum

stratum

https://stratumprotocol.org

Other

223 stars 127 forks source link

Open plebhash opened 5 months ago

plebhash commented 5 months ago

As discussed here, for historical reasons, the FFIs were started with the intention to be imported into Bitcoin Core (TP).

So FFI functionality is currently limited to:

In order to allow firmware integrations (e.g.: https://github.com/skot/ESP-Miner/issues/168), this functionality needs to be expanded with:

plebhash commented 1 month ago

we've been having CI issues with sv2-ffi recently

I feel we should disable CI for sv2-ffi crate until 100% coverage over protocols is achieved

for now, we're not aware of anyone consuming these, so the maintenance burden seems unjustified

Fi3 commented 1 month ago

which is the error?

Fi3 commented 1 month ago

ion sv2-ffi we have tests and header checks. I don't thing we should disable them

plebhash commented 1 month ago

which is the error?

sv2.h hashes are not matching, but that only happens on Github Actions

@jbesraa and I tried reproducing locally on multiple setups without success

Fi3 commented 1 month ago

sorry a typo I meant "in"

plebhash commented 1 month ago

ion sv2-ffi we have tests and header checks. I don't thing we should disable them

the idea here is to disable .github/workflows/sv2-header-check.yaml

we can still leave scripts/{build_header,sv2-header-check}.sh for future reference

Fi3 commented 1 month ago

why? what error do you have? that script is very important

plebhash commented 1 month ago

why? what error do you have? that script is very important

plebhash commented 1 month ago

hiding the discussion to avoid confusion

the core goal of this issue remains: expand FFI functionality to all protocols crates