search

stratum-mining / stratumprotocol.org

Website for the Stratum V2 bitcoin mining protocol
https://stratumprotocol.org
MIT License
13 stars 20 forks source link

Fix image responsiveness #146

Closed pavlenex closed 1 year ago

pavlenex commented 1 year ago

Best example of non-responsive image can be seen here https://deploy-preview-142--startling-capybara-2231ea.netlify.app/getting-started.html

Abhijay007 commented 1 year ago

@pavlenex I want to work on this issue, can you please assign this to me?

pavlenex commented 1 year ago

Sure @Abhijay007 , do you have a time-frame in mind? Bear in mind you'd have to work on top of my PR #142 where image responsiveness issue is visible.

Abhijay007 commented 1 year ago

Sure @Abhijay007 , do you have a time-frame in mind? Bear in mind you'd have to work on top of my PR #142 where image responsiveness issue is visible.

@pavlenex I will start working on it, I am in the process of figuring out how I can resolve this, this may not take that much time, and the other thing is you said I need to work on the top of this PR #142, so do I wait for it to get merge or just fork the changes of that pr and start working on the same?

pavlenex commented 1 year ago

@Abhijay007 I think since that PR is still waiting for some formatting updates, best is to work on top of it, but if you find that the underlaying issue can be fixed otherwise, feel free to work on master and then we can merge your PR first, whatever works for you, I was just able to identify the problem once I added an svg in #142.

Abhijay007 commented 1 year ago

@Abhijay007 I think since that PR is still waiting for some formatting updates, best is to work on top of it, but if you find that the underlying issue can be fixed otherwise, feel free to work on master and then we can merge your PR first, whatever works for you, I was just able to identify the problem once I added an SVG in #142.

Okay, thanks for clearing this @pavlenex, I will start working on the master, and if any of the image responsiveness issues are left after that we will cover that in a new PR if that works.

Abhijay007 commented 1 year ago

@pavlenex after searching around, I found two solutions for this issue

first: we can set a universal style for the image in the index.styl file, as I did here : (attached image below )

one problem with this is that it will give this property to all the images throughout the site, but I don't think that will be an issue because, in most of the images, we different the inline CSS to specific styles, so that might not cause any overwrite issues

second: we can define the CSS for the specific images in the markdown file itself rather than the template.

any thoughts on this ?

image (3)

image (4)

NOTE : also after assigning CSS to the image I re-checked the whole site and nothing changes for the images as most of the images are rendering their CSS from the template where we defined that inline.

pavlenex commented 1 year ago

@Abhijay007 Thanks for quickly tackling this one. If you double-checked that the proposed change doesn't influence other images on the site, I'd say we go with global settings, once you do a PR we will have a test preview via Netlify anyway, so we can double-check.

Abhijay007 commented 1 year ago

@Abhijay007 Thanks for quickly tackling this one. If you double-checked that the proposed change doesn't influence other images on the site, I'd say we go with global settings, once you do a PR we will have a test preview via Netlify anyway, so we can double-check.

sure will open a PR soon :)