search

stratum-mining / stratumprotocol.org

Website for the Stratum V2 bitcoin mining protocol
https://stratumprotocol.org
MIT License
13 stars 20 forks source link

Fixing social media preview image/description #150

Closed joshr4 closed 1 year ago

joshr4 commented 1 year ago

In order to address issue https://github.com/stratum-mining/stratumprotocol.org/issues/147, the open graph meta tags need to be updated.

I believe the reason the preview image isn't loading is due to the content url not being the full url to the asset.

netlify[bot] commented 1 year ago

Deploy Preview for startling-capybara-2231ea ready!

Name Link
Latest commit 1e30edd2626d149c1c289e0ac84d39226729f6c6
Latest deploy log https://app.netlify.com/sites/startling-capybara-2231ea/deploys/63f796ff6dc51c000736afdf
Deploy Preview https://deploy-preview-150--startling-capybara-2231ea.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

joshr4 commented 1 year ago

tested using opengraph.xyz - https://www.opengraph.xyz/url/https%3A%2F%2Fdeploy-preview-150--startling-capybara-2231ea.netlify.app%2F

Screen Shot 2023-02-22 at 6 30 46 PM

The logo is a bit mis-sized, this may be fixed by using a dedicated logo of the right size.

pavlenex commented 1 year ago

@joshr4 Thanks for tackling this one, do you need an image in particular size/ratio, I can help with that, let's try to make it look right from the start :)

joshr4 commented 1 year ago

@pavlenex looks like the image ought to be 1200x630 pixels, here is a nice article with more detailed information https://www.semantica.co.za/everything-you-need-to-know-about-open-graph-images-and-why-they-matter

pavlenex commented 1 year ago

Hey @joshr4 thanks for the resources.

I am not a designer, but I tried to make something out of SV2 logo and background, it's not perfect but I think it will do the job. What do you think?

Twitter-cover-1200x400 v4

joshr4 commented 1 year ago

@pavlenex looks great to me! I went ahead and added the new image. I also updated the content url I have in this PR, but since the new image isn't deployed to prod yet (https://stratumprotocol.org), it won't work. Once this PR is merged, and the image exists at that url, we should be good to go.

pavlenex commented 1 year ago

Thanks for your contribution @joshr4 🎉

Feel free to pick up any other issues you find suitable in the repo.

If you know how to fix formatting in #145 please let me know :)