stratum-mining / stratumprotocol.org

Website for the Stratum V2 bitcoin mining protocol
https://stratumprotocol.org
MIT License
13 stars 20 forks source link

Replace `JN` with `JD` text and `StratumV2` with `Stratum v2` #182

Closed pavlenex closed 1 year ago

pavlenex commented 1 year ago

It doesn't do any contextual edits. We'll have to do some work on docs/index.md in general as it doesn't seem accurate in general. @GitGab19 maybe this edits of /docs/index.md is something you'd like to review in the future, but for now this PR specifically addresses #175 text, image replacement will follow in another PR as I edit out the graphics.

closes #175

netlify[bot] commented 1 year ago

Deploy Preview for startling-capybara-2231ea ready!

Name Link
Latest commit 0615bc959a271bb243e7daacdabfbb9c353d4a02
Latest deploy log https://app.netlify.com/sites/startling-capybara-2231ea/deploys/65200b233ea3aa000775ed33
Deploy Preview https://deploy-preview-182--startling-capybara-2231ea.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

GitGab19 commented 1 year ago

It doesn't do any contextual edits. We'll have to do some work on docs/index.md in general as it doesn't seem accurate in general. @GitGab19 maybe this edits of /docs/index.md is something you'd like to review in the future, but for now this PR specifically addresses #175 text, image replacement will follow in another PR as I edit out the graphics.

closes #175

Agree with you. There is something to change there. Next week I think I'll get time to have a general review and propose some changes!

pavlenex commented 1 year ago

Thanks for a review @GitGab19 Addressed all your suggestions in https://github.com/stratum-mining/stratumprotocol.org/pull/182/commits/82a443ac23604eb511c76f8b8a20b2d14494bd04

There are probably a lot of things we'd have to do in GettingStarted.md as it still has a lot of mentions on JN, but let's do that in a separate PR where we will focus on simplifying docs and ensuring it's correct with our latest changes.

pavlenex commented 1 year ago

@GitGab19 I've reverted the docs/index.md page since you're working on it in #187 so I think we can merge this one.